Skip to content

Conversation

@hf
Copy link
Contributor

@hf hf commented Oct 3, 2023

It appears that in certain client libraries that deal with the OIDC authentication flow, such as this one for React Native on iOS, the clients are unable to extract the nonce that is generated randomly by the library.

This option allows to temporarily drop the enforcement at the GoTrue level when performing the OIDC flow. This does remove an important security barrier, which could potentially allow "stolen" ID tokens to be used on third-party services (that have opted in to this configuration) however in the interest of flexibility and broad platform support the option is being added.

@hf hf requested a review from a team as a code owner October 3, 2023 12:49
@hf hf force-pushed the hf/add-skip-nonce-check-option branch from 187dc21 to 5e8997c Compare October 16, 2023 10:42
@hf hf changed the title feat: add GOTRUE_EXTERNAL_SKIP_NONCE_CHECK to skip nonce checks in ODIC flow feat: add GOTRUE_<PROVIDER>_SKIP_NONCE_CHECK to skip nonce checks in ODIC flow Oct 16, 2023
@hf hf merged commit 4291959 into master Oct 16, 2023
@hf hf deleted the hf/add-skip-nonce-check-option branch October 16, 2023 11:57
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.103.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

hoeseong19 pushed a commit to hoeseong19/gotrue that referenced this pull request Oct 16, 2023
…n ODIC flow (supabase#1264)

It appears that in certain client libraries that deal with the OIDC
authentication flow, such as [this one for React Native on
iOS](google/GoogleSignIn-iOS#244), the clients
are unable to extract the nonce that is generated randomly by the
library.

This option allows to temporarily drop the enforcement at the GoTrue
level when performing the OIDC flow. This does remove an important
security barrier, which could potentially allow "stolen" ID tokens to be
used on third-party services (that have opted in to this configuration)
however in the interest of flexibility and broad platform support the
option is being added.
@KrisBraun
Copy link

@hf Do you know if another change is required to expose this in config.toml for local development? Using the latest CLI (1.33.31) with a auth.external.google.skip_nonce_check option in config.toml without luck.

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
…n ODIC flow (supabase#1264)

It appears that in certain client libraries that deal with the OIDC
authentication flow, such as [this one for React Native on
iOS](google/GoogleSignIn-iOS#244), the clients
are unable to extract the nonce that is generated randomly by the
library.

This option allows to temporarily drop the enforcement at the GoTrue
level when performing the OIDC flow. This does remove an important
security barrier, which could potentially allow "stolen" ID tokens to be
used on third-party services (that have opted in to this configuration)
however in the interest of flexibility and broad platform support the
option is being added.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
…n ODIC flow (supabase#1264)

It appears that in certain client libraries that deal with the OIDC
authentication flow, such as [this one for React Native on
iOS](google/GoogleSignIn-iOS#244), the clients
are unable to extract the nonce that is generated randomly by the
library.

This option allows to temporarily drop the enforcement at the GoTrue
level when performing the OIDC flow. This does remove an important
security barrier, which could potentially allow "stolen" ID tokens to be
used on third-party services (that have opted in to this configuration)
however in the interest of flexibility and broad platform support the
option is being added.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
…n ODIC flow (supabase#1264)

It appears that in certain client libraries that deal with the OIDC
authentication flow, such as [this one for React Native on
iOS](google/GoogleSignIn-iOS#244), the clients
are unable to extract the nonce that is generated randomly by the
library.

This option allows to temporarily drop the enforcement at the GoTrue
level when performing the OIDC flow. This does remove an important
security barrier, which could potentially allow "stolen" ID tokens to be
used on third-party services (that have opted in to this configuration)
however in the interest of flexibility and broad platform support the
option is being added.
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
…n ODIC flow (#1264)

It appears that in certain client libraries that deal with the OIDC
authentication flow, such as [this one for React Native on
iOS](google/GoogleSignIn-iOS#244), the clients
are unable to extract the nonce that is generated randomly by the
library.

This option allows to temporarily drop the enforcement at the GoTrue
level when performing the OIDC flow. This does remove an important
security barrier, which could potentially allow "stolen" ID tokens to be
used on third-party services (that have opted in to this configuration)
however in the interest of flexibility and broad platform support the
option is being added.
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
…n ODIC flow (supabase#1264)

It appears that in certain client libraries that deal with the OIDC
authentication flow, such as [this one for React Native on
iOS](google/GoogleSignIn-iOS#244), the clients
are unable to extract the nonce that is generated randomly by the
library.

This option allows to temporarily drop the enforcement at the GoTrue
level when performing the OIDC flow. This does remove an important
security barrier, which could potentially allow "stolen" ID tokens to be
used on third-party services (that have opted in to this configuration)
however in the interest of flexibility and broad platform support the
option is being added.
fadymak pushed a commit that referenced this pull request Sep 30, 2025
…n ODIC flow (#1264)

It appears that in certain client libraries that deal with the OIDC
authentication flow, such as [this one for React Native on
iOS](google/GoogleSignIn-iOS#244), the clients
are unable to extract the nonce that is generated randomly by the
library.

This option allows to temporarily drop the enforcement at the GoTrue
level when performing the OIDC flow. This does remove an important
security barrier, which could potentially allow "stolen" ID tokens to be
used on third-party services (that have opted in to this configuration)
however in the interest of flexibility and broad platform support the
option is being added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants