Polish up work on #108 on the irispy/time_dependent_response branch#112
Merged
DanRyanIrish merged 5 commits intosunpy:time_dependent_responsefrom Aug 1, 2019
Merged
Conversation
Member
|
Hi @krisastern. I would suggest that Goal 3 be it's own PR. That way this one can be merged more quickly and is easier to review. |
Contributor
Author
|
Sure @DanRyanIrish |
Contributor
Author
|
Hi @DanRyanIrish! Changes made, and the PR is ready for a review. |
DanRyanIrish
requested changes
Aug 1, 2019
Member
DanRyanIrish
left a comment
There was a problem hiding this comment.
Apart from the length of that one line, this looks good!
irispy/iris_tools.py
Outdated
| time_obs: a `numpy.array` of floats, as a kwarg, valid for version > 2 | ||
| Observation times of the datapoints. Must be in the format of the output of time_obs = parse_time('2013-09-03', format='utime'), which yields 1094169600.0 seconds. The argument time_obs is ignored for versions 1 and 2. | ||
| time_obs: an `astropy.time.Time` object, as a kwarg, valid for version > 2 | ||
| Observation times of the datapoints. Must be in the format of , e.g., time_obs = parse_time('2013-09-03', format='utime'), which yields 1094169600.0 seconds in value. The argument time_obs is ignored for versions 1 and 2. |
Member
There was a problem hiding this comment.
PEP 8 compliance: Can you break this into multiple lines no line hits the 100 character mark?
Member
|
Great. Once it passes the CI tests, I'll approve and merge :) |
DanRyanIrish
approved these changes
Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
versionnorfilehas been explicitly passed to theget_iris_responsemethod.time_obsvariable from a numpy.array to an astropy.time.Time object.