Support for case conversion helpers.#619
Merged
Merged
Conversation
Helpers for converting a text string to `camelCase`, `kebab-case`, `snake_case` etc. Supports case conversions from the `heck` crate. This is an opt-in feature which can be enabled using `string_helpers` feature.
sunng87
reviewed
Nov 6, 2023
| _rc: &mut crate::render::RenderContext<'_, '_>, | ||
| out: &mut dyn crate::output::Output, | ||
| ) -> crate::helpers::HelperResult { | ||
| let param = h.param(0).and_then(|v| v.value().as_str()).unwrap_or(""); |
Owner
There was a problem hiding this comment.
Perhaps we can throw an error for non-string input here?
The error system is slightly different between 4.x and upcoming 5.x so I can do it for you.
sunng87
approved these changes
Nov 6, 2023
Owner
|
LGTM. I will be cherry-picking this to 4.x branch and update error handling. |
sunng87
pushed a commit
that referenced
this pull request
Nov 6, 2023
Helpers for converting a text string to `camelCase`, `kebab-case`, `snake_case` etc. Supports case conversions from the `heck` crate. This is an opt-in feature which can be enabled using `string_helpers` feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpers for converting a text string to
camelCase,kebab-case,snake_caseetc. Supports case conversions from theheckcrate. This is an opt-in feature which can be enabled usingstring_helpersfeature.