Fix issue when using partial context within each block#536
Merged
Conversation
The context for partial block is wrong when included in a each block
1bbd495 to
eb56b39
Compare
133030c to
364ff85
Compare
sunng87
added a commit
that referenced
this pull request
Oct 5, 2022
Fix issue when using partial context within each block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #534
In previous implementation, block are pushed to render context at last. However, during the context merge phase, we use
Path::current()which assumes block already pushed to render context. This patch reorganized its sequence to make sure context is merged with given path.