Skip to content

fix(di.inversify,core): use node util instead of lodash.isequal#783

Merged
omermorad merged 4 commits into
suites-dev:nextfrom
HarrySky:refactor/remove-lodash-isequal
Aug 18, 2025
Merged

fix(di.inversify,core): use node util instead of lodash.isequal#783
omermorad merged 4 commits into
suites-dev:nextfrom
HarrySky:refactor/remove-lodash-isequal

Conversation

@HarrySky

Copy link
Copy Markdown
Contributor

Hi, lodash.isequal package warns that it is deprecated:
"This package is deprecated. Use require('node:util').isDeepStrictEqual instead."

As suites is used for testing backend (Node.js) applications - places where it was used can use isDeepStrictEqual from node:util

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

It prints about lodash.isequal deprecation when I install your package

Issue Number: N/A

What is the new behavior?

It should no longer bother me with lodash.isequal deprecation message

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I ran yarn test and yarn lint according to the CONTRIBUTING.md, let me know if there is something I missed

The package warns that it is deprecated:
"This package is deprecated. Use require('node:util').isDeepStrictEqual instead."

Places where it was used now use isDeepStrictEqual from node:util
@omermorad omermorad changed the title Remove lodash.isequal fix(di.inversify,core): use node util instead of lodash.isequal Aug 18, 2025
@omermorad omermorad changed the base branch from master to next August 18, 2025 10:34
@codecov

codecov Bot commented Aug 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (next@7849cd5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #783   +/-   ##
=======================================
  Coverage        ?   92.52%           
=======================================
  Files           ?       26           
  Lines           ?      589           
  Branches        ?       99           
=======================================
  Hits            ?      545           
  Misses          ?       35           
  Partials        ?        9           
Flag Coverage Δ
core.unit 93.44% <100.00%> (?)
di.inversify 93.68% <100.00%> (?)
di.nestjs 87.25% <ø> (?)
doubles.jest 100.00% <ø> (?)
doubles.sinon 100.00% <ø> (?)
doubles.vitest 100.00% <ø> (?)
unit 77.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omermorad

Copy link
Copy Markdown
Collaborator

@HarrySky thank you for contributing! 🎉😄

@omermorad omermorad merged commit d587b58 into suites-dev:next Aug 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants