Skip to content

fix: reflect metadta peer dependency#463

Merged
omermorad merged 3 commits into
nextfrom
peer_reflect_metadata
Oct 18, 2024
Merged

fix: reflect metadta peer dependency#463
omermorad merged 3 commits into
nextfrom
peer_reflect_metadata

Conversation

@qballer

@qballer qballer commented Oct 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

I've update peer dependencies where needed.
I've also sorted the root package.json like the linter suggested.

  • Bugfix

Issue Number: #461

Does this PR introduce a breaking change?

  • No

@qballer qballer requested a review from omermorad October 11, 2024 14:17
@codecov

codecov Bot commented Oct 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@4e3e6ba). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next     #463   +/-   ##
=======================================
  Coverage        ?   93.30%           
=======================================
  Files           ?       25           
  Lines           ?      568           
  Branches        ?       94           
=======================================
  Hits            ?      530           
  Misses          ?       30           
  Partials        ?        8
Flag Coverage Δ
core.unit 95.67% <ø> (?)
di.inversify 93.68% <ø> (?)
di.nestjs 87.25% <ø> (?)
doubles.jest 100.00% <ø> (?)
doubles.sinon 100.00% <ø> (?)
doubles.vitest 100.00% <ø> (?)
unit 77.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qballer qballer force-pushed the peer_reflect_metadata branch from fee8e5e to dc6a3d4 Compare October 11, 2024 14:22
@qballer qballer force-pushed the peer_reflect_metadata branch from e914361 to 336621d Compare October 11, 2024 14:29
omermorad
omermorad reviewed Oct 13, 2024
View reviewed changes
Comment thread packages/di/inversify/package.json Outdated
Comment thread packages/di/nestjs/package.json Outdated
@qballer qballer requested a review from omermorad October 13, 2024 19:56
@qballer qballer force-pushed the peer_reflect_metadata branch 2 times, most recently from bc7d812 to 5bd3118 Compare October 18, 2024 08:13
@qballer qballer force-pushed the peer_reflect_metadata branch from 5bd3118 to 470599b Compare October 18, 2024 08:16
@omermorad omermorad changed the base branch from master to next October 18, 2024 11:01
@omermorad omermorad merged commit 164ff93 into next Oct 18, 2024
@omermorad omermorad deleted the peer_reflect_metadata branch October 18, 2024 11:03
omermorad pushed a commit that referenced this pull request Jan 1, 2025
@qballer @omermorad
fix(di.nestjs,di.inversify): reflect metadta peer dependency (#463)
60ca946
omermorad pushed a commit that referenced this pull request Jan 2, 2025
@qballer @omermorad
fix(di.nestjs,di.inversify): reflect metadta peer dependency (#463)
81367c2
omermorad pushed a commit that referenced this pull request Jan 2, 2025
@qballer @omermorad
fix(di.nestjs,di.inversify): reflect metadta peer dependency (#463)
be3e714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omermorad omermorad Awaiting requested review from omermorad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qballer @omermorad