Fix theme directory path for bun bundler flat output#279
Merged
Conversation
The getThemesDir() function incorrectly navigated up one directory when resolving bundled theme paths in the dist build. This caused "Theme file not found" errors when using --theme with bundled themes like dracula in npm-installed packages. The bug was caused by outdated path logic that assumed bun's bundler would preserve directory structure (dist/tui/theme.js), when it actually produces flat output (dist/cli.js). The fix removes the unnecessary parent directory traversal. Fixes #277 https://claude.ai/code/session_01WrY1zjHuxQ1ddiJNDfqVqi
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
WalkthroughUpdates the path resolution logic in the theme directory lookup function to accommodate a flattened dist bundle layout. The resolution path for the bundled theme assets changes from a nested structure to a flat structure, while development mode behaviour remains unaffected. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 43.70% 43.70% -0.01%
==========================================
Files 94 94
Lines 29021 29022 +1
==========================================
Hits 12684 12684
- Misses 16337 16338 +1
🚀 New features to boost your workflow:
|
sakaman
pushed a commit
to sakaman/ralph-tui
that referenced
this pull request
Feb 15, 2026
…TCvtD Fix theme directory path for bun bundler flat output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the theme directory resolution logic to correctly handle the bun bundler's flat output structure, where the compiled CLI is located at
dist/cli.jsrather than in a nested directory structure.Changes
../assets/themestoassets/themesto match bun's flat bundling outputdist/tui/theme.js) and bun's flat output (dist/cli.js)dist/assets/themeswhen running the bundled CLIImplementation Details
The fix leverages the existing
isInDistcheck that detects when code is running from the dist directory. Since bun produces a flat output structure wherecli.jsis directly in the dist root (rather than nested indist/tui/), the relative path to assets needs to be adjusted accordingly. The development path resolution remains unchanged.https://claude.ai/code/session_01WrY1zjHuxQ1ddiJNDfqVqi
Summary by CodeRabbit
Release Notes