Merged
Conversation
The useEffect for prompt preview depended on `displayedTasks` and `iterations` arrays, which could have unstable references causing the effect to fire repeatedly on every render. Fix: Extract task ID computation into a memoized `promptPreviewTaskId` value, then have the useEffect depend on that stable string instead of the full arrays. This prevents the re-render loop since the string only changes when the actual selection changes.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
WalkthroughA refactoring of the RunApp component introduces a memoized Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 tasks
sakaman
pushed a commit
to sakaman/ralph-tui
that referenced
this pull request
Feb 15, 2026
Fix prompt preview pane flickering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes rapid flickering/redraw when viewing the prompt preview pane (Shift+O).
Root Cause
The
useEffectthat generates prompt previews depended ondisplayedTasksanditerationsarrays:If these arrays get new references (common in React), the effect fires repeatedly, calling
setPromptPreviewwhich triggers another render → infinite loop.Fix
Extract the task ID into a memoized value, then depend on that stable string:
Test plan
Summary by CodeRabbit
Release Notes