Increase process timeout from 5s to 15s for agent version checks#256
Merged
Increase process timeout from 5s to 15s for agent version checks#256
Conversation
On Windows, spawning gemini.cmd through shell adds significant overhead due to cmd.exe parsing the .cmd wrapper and Node.js cold start time. The previous 5-second timeout was too aggressive, causing false "Timeout waiting for --version" errors on slower systems. Fixes #239 https://claude.ai/code/session_01T4PgaBiMhwnWNwx7xuej4G
Extends the timeout increase from gemini to all agents and the base findCommandPath function. On Windows, spawning CLI tools through shell adds overhead that can exceed 5 seconds on slower systems. Files updated: - base.ts: findCommandPath() and BaseAgentPlugin.detect() - claude.ts, codex.ts, kiro.ts, opencode.ts: runVersion() Fixes #239 https://claude.ai/code/session_01T4PgaBiMhwnWNwx7xuej4G
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughTimeouts for spawned CLI processes and command-path detection were increased from 5000ms to 15000ms across the base agent and several builtin agent plugins (Claude, Codex, Gemini, Kiro, OpenCode). No API signatures were changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 45.70% 45.70%
=======================================
Files 91 91
Lines 27442 27442
=======================================
Hits 12542 12542
Misses 14900 14900
🚀 New features to boost your workflow:
|
sakaman
pushed a commit
to sakaman/ralph-tui
that referenced
this pull request
Feb 15, 2026
…ErpHX Increase process timeout from 5s to 15s for agent version checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increased the timeout duration for agent process version checks from 5 seconds to 15 seconds across all agent plugins. This change provides more time for slower systems or environments to complete version detection without premature timeout failures.
Changes
findCommandPath()in base agent plugin (5s → 15s)BaseAgentPlugin.checkVersion()(5s → 15s)ClaudeAgentPlugin.checkVersion()(5s → 15s)CodexAgentPlugin.checkVersion()(5s → 15s)GeminiAgentPlugin.checkVersion()(5s → 15s)KiroAgentPlugin.checkVersion()(5s → 15s)OpenCodeAgentPlugin.checkVersion()(5s → 15s)Rationale
The 5-second timeout was too aggressive for certain environments, potentially causing false negatives when detecting available agents. Increasing to 15 seconds provides a more reasonable grace period while still maintaining responsiveness for truly unavailable agents.
https://claude.ai/code/session_01T4PgaBiMhwnWNwx7xuej4G
Summary by CodeRabbit