docs: Add analysis for issue #244 - Start not working after refresh#251
Merged
docs: Add analysis for issue #244 - Start not working after refresh#251
Conversation
Root cause: 's' key handler doesn't handle 'complete' status. When engine completes all tasks and new ones are created externally, pressing 's' after refresh does nothing. Proposed fix: Add 'complete' to the status check in the 's' handler. https://claude.ai/code/session_01MswFvQsQ7NQB7ypr3JsESE
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
WalkthroughExpanded TUI start/continue logic to treat a completed run as actionable: the 's' key now triggers continuation when display status is Changes
Sequence Diagram(s)sequenceDiagram
participant User as User (press 's')
participant TUI as RunApp / TUI
participant Engine as Local Engine
participant Remote as Remote Instance
User->>TUI: press 's'
alt displayStatus == 'ready' and onStart exists
TUI->>Engine: trigger onStart (initial start)
else displayStatus in ('stopped','idle','complete')
alt viewing remote instance
TUI->>Remote: send "continue" command
Remote-->>TUI: acknowledge
else local engine
TUI->>Engine: trigger continueExecution
Engine-->>TUI: new tasks / status updates
end
else other statuses
TUI-->>User: no-op
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
When all tasks were completed and new tasks were created externally, pressing 's' after refresh did nothing because the handler only recognized 'stopped' and 'idle' statuses. Changes: - Add 'complete' to the status check in 's' key handler (line 1431) - Add 'complete' to remote instance continue command check (line 1422) - Add comprehensive tests for keyboard handler status logic Fixes #244 https://claude.ai/code/session_01MswFvQsQ7NQB7ypr3JsESE
sakaman
pushed a commit
to sakaman/ralph-tui
that referenced
this pull request
Feb 15, 2026
…wl3t5 docs: Add analysis for issue subsy#244 - Start not working after refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a detailed analysis document for issue #244, which describes a bug where newly created tasks cannot be started in ralph-tui after refreshing when the engine has previously completed all tasks.
Changes
.claude/issue-244-analysis.mdwith comprehensive root cause analysisKey Findings
The issue occurs because:
'complete''ready','stopped', or'idle'statuses'complete'and the handler ignores the 's' key press'complete'to the status check in the 's' key handlerThis analysis document serves as a reference for implementing the fix and understanding the interaction between engine state and TUI status management.
https://claude.ai/code/session_01MswFvQsQ7NQB7ypr3JsESE
Summary by CodeRabbit
Bug Fixes
Tests
Documentation