fix(codex): honor sandbox when full-auto is enabled by dyxushuai · Pull Request #245 · subsy/ralph-tui

dyxushuai · 2026-01-31T11:14:25Z

Why

--full-auto forces workspace-write and overrides user-selected sandbox
This prevents Codex tool calls (e.g., agent-browser) from accessing required paths

How

Use global "-a on-request" when fullAuto is true and sandbox is customized
Keep --full-auto only for the default workspace-write sandbox
Add a test to lock the behavior

Tests

bun run typecheck
bun run build

Summary by CodeRabbit

Bug Fixes
- Corrected argument ordering and flag handling when full-auto is enabled with custom sandboxes so approval flow and sandbox flags behave correctly.
Tests
- Added tests for full-auto with different custom sandboxes (read-only, danger-full-access) to verify generated argument order and sandbox propagation.
Documentation
- Clarified default vs custom sandbox behaviour with examples and added an informational callout describing the CLI argument patterns.

vercel · 2026-01-31T11:14:29Z

@dyxushuai is attempting to deploy a commit to the plgeek Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2026-01-31T11:14:48Z

Walkthrough

CodexAgentPlugin.buildArgs now separates preliminary args (preArgs) from main args and changes fullAuto handling: when fullAuto is set and sandbox is not workspace-write, the plugin emits -a on-request in preArgs and omits --full-auto; exec placement adjusted. Tests and docs added for custom sandboxes.

Changes

Cohort / File(s)	Summary
Codex agent implementation & tests `src/plugins/agents/builtin/codex.ts`, `src/plugins/agents/builtin/codex.test.ts`	Introduce `preArgs` and return combined `[...]preArgs, ...args`; emit `-a on-request` in `preArgs` when `fullAuto` && `sandbox` !== `workspace-write`; only emit `--full-auto` when `sandbox` is `workspace-write`. Added tests verifying argument order (`-a` before `exec`) and sandbox flag propagation for `danger-full-access` and `read-only`.
Documentation `website/content/docs/plugins/agents/codex.mdx`	Add callout describing Codex custom sandbox behaviour with `fullAuto`; update CLI examples showing default sandbox flow (uses `--full-auto`) and custom sandbox flow (uses `-a on-request` before `exec`, with `--sandbox danger-full-access`).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: ensuring that custom sandbox settings are honoured when full-auto mode is enabled, which is the core fix addressed throughout the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR fixes an issue where the --full-auto flag in the Codex CLI agent was forcing the workspace-write sandbox mode, overriding user-selected custom sandboxes. This prevented Codex tool calls from accessing required paths when users specified alternative sandbox modes.

Changes:

Modified the argument building logic to use -a on-request global flag when fullAuto is enabled with a non-default sandbox
Introduced preArgs array to properly order global flags before the subcommand
Added test coverage to verify the new behavior with custom sandbox configurations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/plugins/agents/builtin/codex.ts	Updated buildArgs method to conditionally use approval flag instead of --full-auto when custom sandbox is specified, ensuring global flags are placed before subcommand
src/plugins/agents/builtin/codex.test.ts	Added test case to verify that approval flag is used correctly when fullAuto is enabled with a custom sandbox

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/plugins/agents/builtin/codex.test.ts

Address PR review feedback: - Verify --sandbox flag is still correctly included when using approval flag instead of --full-auto - Add test for read-only sandbox to ensure behavior works for all non-default sandbox values, not just danger-full-access

vercel · 2026-02-03T18:20:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
ralph-tui	Ignored	Preview	Feb 3, 2026 6:26pm

Explain that when fullAuto is enabled with a custom sandbox mode (read-only or danger-full-access), Ralph TUI uses -a on-request instead of --full-auto to honor the sandbox setting. Update CLI arguments section to show both command formats.

subsy · 2026-02-03T18:22:20Z

thanks for this @dyxushuai 🤘
Addressed some PR feedback and added docs

--full-auto is a subcommand flag that must come after exec. Only -a (global approval flag) needs to precede the exec subcommand. Fixes test failure: Expected args[0] to be 'exec', not '--full-auto'

codecov · 2026-02-03T18:27:58Z

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.49%. Comparing base (b86661d) to head (45538bd).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
src/plugins/agents/builtin/codex.ts	60.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   43.49%   43.49%           
=======================================
  Files          92       92           
  Lines       28351    28358    +7     
=======================================
+ Hits        12330    12334    +4     
- Misses      16021    16024    +3

Files with missing lines	Coverage Δ
src/plugins/agents/builtin/codex.ts	`49.01% <60.00%> (+0.14%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix(codex): honor sandbox when full-auto is enabled

fix(codex): respect sandbox when full-auto

413323c

Copilot AI review requested due to automatic review settings January 31, 2026 11:14

Copilot started reviewing on behalf of dyxushuai January 31, 2026 11:14 View session

Copilot AI reviewed Jan 31, 2026

View reviewed changes

src/plugins/agents/builtin/codex.test.ts Show resolved Hide resolved

src/plugins/agents/builtin/codex.test.ts Show resolved Hide resolved

dyxushuai and others added 3 commits February 3, 2026 17:14

Merge branch 'main' into fix/codex-full-auto-sandbox

fea2159

Merge branch 'main' into fix/codex-full-auto-sandbox

027c1c7

vercel bot deployed to Preview February 3, 2026 18:21 View deployment

subsy force-pushed the fix/codex-full-auto-sandbox branch from 3db8b3e to 489cac5 Compare February 3, 2026 18:21

vercel bot deployed to Preview February 3, 2026 18:22 View deployment

fix(codex): preserve exec subcommand position in args

45538bd

--full-auto is a subcommand flag that must come after exec. Only -a (global approval flag) needs to precede the exec subcommand. Fixes test failure: Expected args[0] to be 'exec', not '--full-auto'

subsy merged commit 0c00b11 into subsy:main Feb 3, 2026
9 checks passed

sakaman pushed a commit to sakaman/ralph-tui that referenced this pull request Feb 15, 2026

Merge pull request subsy#245 from dyxushuai/fix/codex-full-auto-sandbox

b509065

fix(codex): honor sandbox when full-auto is enabled

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(codex): honor sandbox when full-auto is enabled#245

fix(codex): honor sandbox when full-auto is enabled#245
subsy merged 6 commits intosubsy:mainfrom
dyxushuai:fix/codex-full-auto-sandbox

dyxushuai commented Jan 31, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jan 31, 2026

Uh oh!

coderabbitai bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

subsy commented Feb 3, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dyxushuai commented Jan 31, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jan 31, 2026

Uh oh!

coderabbitai bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

subsy commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dyxushuai commented Jan 31, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 31, 2026 •

edited

Loading

vercel bot commented Feb 3, 2026 •

edited

Loading

subsy commented Feb 3, 2026 •

edited

Loading

codecov bot commented Feb 3, 2026 •

edited

Loading