Skip to content

refactor: copy test PRD to workspace instead of modifying source#243

Merged
subsy merged 1 commit intomainfrom
claude/testing-copy-prd-to-workspace-CT50f
Jan 30, 2026
Merged

refactor: copy test PRD to workspace instead of modifying source#243
subsy merged 1 commit intomainfrom
claude/testing-copy-prd-to-workspace-CT50f

Conversation

@subsy
Copy link
Copy Markdown
Owner

@subsy subsy commented Jan 30, 2026 •
edited by coderabbitai bot
Loading

Previously, ralph-tui would modify testing/test-prd.json directly, which could lead to accidental commits of test state.

Now:

  • setup-test-workspace.sh copies test-prd.json to workspace
  • ralph-tui modifies the workspace copy during runs
  • reset-test.sh re-copies from source to restore clean state

The source testing/test-prd.json is now a template that never changes.

https://claude.ai/code/session_019Q1N2XskiaS1omXVN3Xrt2

Summary by CodeRabbit

  • Documentation

    • Enhanced testing documentation with clearer guidance on PRD workflow and workspace environment behaviour.

  • Chores

    • Optimised test workspace setup and reset procedures for improved consistency and user guidance across testing operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@claude
refactor: copy test PRD to workspace instead of modifying source
217a7c2 
Previously, ralph-tui would modify testing/test-prd.json directly,
which could lead to accidental commits of test state.

Now:
- setup-test-workspace.sh copies test-prd.json to workspace
- ralph-tui modifies the workspace copy during runs
- reset-test.sh re-copies from source to restore clean state

The source testing/test-prd.json is now a template that never changes.

https://claude.ai/code/session_019Q1N2XskiaS1omXVN3Xrt2
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ralph-tui Ignored Ignored Jan 30, 2026 2:45pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 30, 2026 •
edited
Loading

Walkthrough

The pull request updates testing documentation and scripts to implement a workspace-copy model for the test PRD file. Rather than modifying the source template in-place, the workflow now copies test-prd.json into the workspace during setup and resets by recopying from source, with corresponding documentation updates explaining this behaviour.

Changes

Cohort / File(s) Summary
Testing Scripts
testing/reset-test.sh, testing/setup-test-workspace.sh		 Modified to implement workspace-copy workflow. Setup now includes a step to copy test-prd.json to the workspace (step count increased from 5 to 6). Reset logic changed from in-place JSON modification (jq/perl) to copying from source file. Updated messaging and path references throughout.
Testing Documentation
testing/TESTING.md		 Updated to reflect workspace-copy model. Added explanatory section "How the PRD Works" describing template behaviour and state restoration. Revised run commands, verification steps, and contributor instructions to reference workspace-based test-prd.json. Updated "What Gets Shared with Contributors" table to clarify template vs. committed state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • PR #242: Introduces the same workspace-copy pattern changes to testing/setup-test-workspace.sh and testing/reset-test.sh, providing the initial implementation of this workflow model.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: refactoring the testing workflow to copy the test PRD to the workspace instead of modifying the source file directly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/testing-copy-prd-to-workspace-CT50f

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@subsy subsy merged commit 17bcefc into main Jan 30, 2026
9 checks passed
@subsy subsy deleted the claude/testing-copy-prd-to-workspace-CT50f branch January 30, 2026 14:51
@coderabbitai coderabbitai bot mentioned this pull request Feb 4, 2026
Merged
6 tasks
sakaman pushed a commit to sakaman/ralph-tui that referenced this pull request Feb 15, 2026
@subsy
Merge pull request subsy#243 from subsy/claude/testing-copy-prd-to-wo…
c9112f1 
…rkspace-CT50f

refactor: copy test PRD to workspace instead of modifying source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@subsy @claude