Add failing test for top level transforms and symlinked node modules#1365
Closed
ivantsepp wants to merge 1 commit intobrowserify:masterfrom
Closed
Add failing test for top level transforms and symlinked node modules#1365ivantsepp wants to merge 1 commit intobrowserify:masterfrom
ivantsepp wants to merge 1 commit intobrowserify:masterfrom
Conversation
Author
|
Any updates on this? Is the test in this PR expected behavior? |
Collaborator
|
@ivantsepp Thanks for this! I haven't tried your test (and unfortunately I can't manage to fully "get it" just from the description), but there's some discussion going on in #1386 that you may be interested in. |
This was referenced Sep 24, 2015
Member
|
I guess this is fixed by #1392 |
Contributor
Member
|
@chrisirhc cool! Lets let ppl chime in on #1413 since that'll bump browserify to v12, so then #1392 can ride along with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a failing test with using a transform on top-level files on symlinked node modules.
The test failure is coming from passing in the realpath and
module-depsuses this path to determine if the file is top level.A possible solution is to not pass in the realpath and calculate it instead in
module-deps. I think this makes sense asmodule-depswould want to know the realpath and the resolved path of the file.