do not apply root transforms on linked modules#1392
Closed
chrisirhc wants to merge 3 commits intobrowserify:masterfrom
Closed
do not apply root transforms on linked modules#1392chrisirhc wants to merge 3 commits intobrowserify:masterfrom
chrisirhc wants to merge 3 commits intobrowserify:masterfrom
Conversation
resolver in module-deps now accepts a 4th argument which should be the original (non-real) file path.
Contributor
Author
|
Updated to use module-deps 4.0.0, so that tests pass. |
This was referenced Oct 26, 2015
|
Merged into 12.0.1. I thought we had this in 12.0.0 but I think it slipped through the cracks. Thanks for all the great work! |
|
🎉 thanks for merging and thanks @chrisirhc for the fix 😄 |
1 task
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incudes tests from #1365 and fixes #1365 , fixes #1386.
This will fail until browserify/module-deps#99 is merged and released on module-deps. I'll re-run when that's done.