do not apply root transforms on linked modules#99
Merged
1 commit merged intobrowserify:masterfrom Oct 16, 2015
Merged
Conversation
resolver now accepts a 4th argument which should be the original (non-real) file path.
This was referenced Sep 24, 2015
|
Thanks! I've published this as 4.0.0 to be extra cautious since in previous releases symlink issues have been very sensitive. I think we can put this into the browserify v12 release. |
Contributor
Author
|
Sounds good to me. I didn't add tests, but I can look into adding them later. Wasn't sure if this solution was of interest. |
zertosh
added a commit
to browserify/browserify
that referenced
this pull request
Oct 26, 2015
This was referenced Dec 6, 2015
1 task
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolver now accepts a 4th argument which should be the original
(non-real) file path.
Required for fixing browserify/browserify#1386 / browserify/browserify#1365
Definitely could use a better variable name, so this is open for suggestion and comments.
This change is missing tests right now. I'll add them if I get some feedback that we might want to merge this.