[Markdown] Fix reference to Javascript Syntax#1618
Merged
Conversation
The Javascript syntax uses `source.js`. This caused failures in syntect where a broken reference is an error, which perhaps it shouldn't be if it isn't in Sublime. cc @keith-hall
Collaborator
|
Can you rename the PR to start with the package name in brackets, please - just to quickly see which package is addressed. [Markdown] Fix reference to Javascript Syntax |
Collaborator
|
maybe it'd make sense to add a (loose) test assertion on some of the JS code inside the fence - if I had done this we would have caught it sooner ;) |
Contributor
Author
|
@keith-hall done. |
keith-hall
approved these changes
May 27, 2018
charlievieth
pushed a commit
to charlievieth/Packages
that referenced
this pull request
Jul 25, 2018
deathaxe
pushed a commit
to deathaxe/sublime-packages
that referenced
this pull request
Jun 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Javascript syntax uses
source.js. This caused failures in syntect where a broken reference is an error, which perhaps it shouldn't be if it isn't in Sublime.cc @keith-hall