Fix missing phase angle in calculation of grid velocity for rigid pitching motion#1656
Merged
pcarruscag merged 3 commits intosu2code:developfrom Jun 4, 2022
HL-ZHI:master
Merged
Fix missing phase angle in calculation of grid velocity for rigid pitching motion#1656pcarruscag merged 3 commits intosu2code:developfrom HL-ZHI:master
pcarruscag merged 3 commits intosu2code:developfrom
HL-ZHI:master
Conversation
Member
|
I forgot, please add yourself (either name or GitHub handle) to the AUTHORS.md file (alphabetical order). |
Contributor
Author
Done. #1657 |
WallyMaier
approved these changes
Jun 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For RIGID_PITCHING movement, add PHASE parameter to angular velocities.
Pitching angle: angle=Ampl * sin(Omega * Time + Phase)
Original augular velocity: AlphaDot = Omega * Ampl * cos(Omega *Time)
Updated angular velocity: AlphaDot = Omega * Ampl * cos(Omega *Time + Phase)
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.