Skip to content

Update master#1590

Merged
pcarruscag merged 294 commits intomasterfrom
develop
Apr 2, 2022
Merged

Update master#1590
pcarruscag merged 294 commits intomasterfrom
develop

Conversation

@pcarruscag
Copy link
Member

No description provided.

TobiKattmann and others added 30 commits January 31, 2022 12:22
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
makes comparing cases a little less annoying
Used a 3D cht case and applied it in the solid zone. Residual stay exactly the same.
This, to my experience is only the case because the surface is a plane rectangle.
For e.g. a round shape the small mismatch in exact circle circumference and the discrete
appriximation by the mesh is enough to alter the residuals (and final temperature)
slighthly. The Residual change in this case for the Temperature is due to the error that
was in the mesh (see Testcases #91)
In multizone everything is done again + attaching the zone indices. So one
had to do the AddHistPerSurf and SetHistPerSurf for multizone again.
When using WALL_TIME as the first SCREEN_OUTPUT field, in Testcase.py,
the code would never reach the iter_missing=True block as the line would
produce a ValueError for every line. And because the default was
iter_missing=False and passed=True ... the test reports passed.
Setting the defaults to the non-passed version fixes that issue.
….. which I believe is not clever programming, especially for regression tests.
Otherwise a pre-5.1 version of GCC, using std=gnu89 by default,
complains about the for loop initial declaration in
externals/cgns/cgnslib.c.
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
TobiKattmann and others added 24 commits March 23, 2022 16:51
Fix CGNS mesh reader for multizone problems (one CGNS mesh per zone)
Fix some "resource not released in destructor" warnings
* added file dependent writing frequency
* use OUTPUT_WRT_FREQ instead of new config option
* removed *volumeoutputfrequencies
* save freeformdefbox for another PR. print list of writing frequencies
* only print file frequency when there are output files
* Apply suggestions from code review
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
* Fix spelling mistakes
Allow field groups in SCREEN_OUTPUT (e.g. RMS_RES like for HISTORY_OUTPUT)
Changing version number to 7.3.1
@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2022

This pull request fixes 13 alerts when merging 328a1b7 into 72b2fa9 - view on LGTM.com

fixed alerts:

  • 8 for Resource not released in destructor
  • 5 for Comparison of narrow type with wide type in loop condition

@pcarruscag pcarruscag merged commit 42d1571 into master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.