Merged
Conversation
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
…into feature_integratedHF
makes comparing cases a little less annoying
Used a 3D cht case and applied it in the solid zone. Residual stay exactly the same. This, to my experience is only the case because the surface is a plane rectangle. For e.g. a round shape the small mismatch in exact circle circumference and the discrete appriximation by the mesh is enough to alter the residuals (and final temperature) slighthly. The Residual change in this case for the Temperature is due to the error that was in the mesh (see Testcases #91)
In multizone everything is done again + attaching the zone indices. So one had to do the AddHistPerSurf and SetHistPerSurf for multizone again.
…to massflow_flowmeta
When using WALL_TIME as the first SCREEN_OUTPUT field, in Testcase.py, the code would never reach the iter_missing=True block as the line would produce a ValueError for every line. And because the default was iter_missing=False and passed=True ... the test reports passed. Setting the defaults to the non-passed version fixes that issue.
….. which I believe is not clever programming, especially for regression tests.
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Bugfix: temporary config filename
Clean air-nozzle cfg
Fix CGNS mesh reader for multizone problems (one CGNS mesh per zone)
…_released_in_dtor
Fix some "resource not released in destructor" warnings
* added file dependent writing frequency * use OUTPUT_WRT_FREQ instead of new config option * removed *volumeoutputfrequencies * save freeformdefbox for another PR. print list of writing frequencies * only print file frequency when there are output files * Apply suggestions from code review Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
* Fix spelling mistakes
…u2code/SU2 into allow_groups_for_screen_output
Allow field groups in SCREEN_OUTPUT (e.g. RMS_RES like for HISTORY_OUTPUT)
Changing version number to 7.3.1
|
This pull request fixes 13 alerts when merging 328a1b7 into 72b2fa9 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.