Skip to content

Fixes #1568 - Prefer loading zlib and szip libraries dynamically#1632

Merged
pcarruscag merged 1 commit intosu2code:developfrom
martin-g:1568-load-zlib-szip-dynamically
May 12, 2022
Merged

Fixes #1568 - Prefer loading zlib and szip libraries dynamically#1632
pcarruscag merged 1 commit intosu2code:developfrom
martin-g:1568-load-zlib-szip-dynamically

Conversation

@martin-g
Copy link
Member

Proposed Changes

Changes the loading of zlib and szip libraries from static (.a) to dynamic (.so).
Suggested by @aa-g at #1568 (comment).

Related Work

None.

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Fixes the following error on Ubuntu 20.04:

/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libz.a(deflate.o): relocation R_X86_64_PC32 against symbol `z_errmsg' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
[814/816] Compiling C++ object UnitTests/test_driver.p/test_driver.cpp.o
ninja: build stopped: subcommand failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue building python wrapper with CGNS support (problems with static/dynamic HDF5 dependencies)

2 participants