Fixes #1568 - Prefer loading zlib and szip libraries dynamically#1632
Merged
pcarruscag merged 1 commit intosu2code:developfrom May 12, 2022
martin-g:1568-load-zlib-szip-dynamically
Merged
Fixes #1568 - Prefer loading zlib and szip libraries dynamically#1632pcarruscag merged 1 commit intosu2code:developfrom martin-g:1568-load-zlib-szip-dynamically
pcarruscag merged 1 commit intosu2code:developfrom
martin-g:1568-load-zlib-szip-dynamically
Conversation
Fixes the following error on Ubuntu 20.04: /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libz.a(deflate.o): relocation R_X86_64_PC32 against symbol `z_errmsg' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status [814/816] Compiling C++ object UnitTests/test_driver.p/test_driver.cpp.o ninja: build stopped: subcommand failed.
pcarruscag
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Changes the loading of zlib and szip libraries from static (.a) to dynamic (.so).
Suggested by @aa-g at #1568 (comment).
Related Work
None.
PR Checklist