Fix running averages for restarted simulations#1601
Merged
TobiKattmann merged 4 commits intodevelopfrom Apr 12, 2022
Merged
Conversation
When restarted at e.g. Time-Iter 2 the first value would be divided by 3 (number of timesteps counting from zero). So if your first value in that restarted sim is a 3, the running average would be 1. This is fixed with this commit by setting WINDOW_START_ITER = RESTART_ITER in the Config Postprocessing, if the option is not set. If the option is set, but incorrectly, an error is raised.
TobiKattmann
commented
Apr 11, 2022
pcarruscag
approved these changes
Apr 11, 2022
Tiny change to exactly have the github worklfow values
Contributor
Author
|
Thanks for the review :) Once the tests pass with this tiny commited regression value change for the hybrid case - I'll merge this in |
Member
|
Sounds good thanks for the fix. |
WallyMaier
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When restarted at e.g. Time-Iter 2 the first value would be divided by 3 (number of timesteps counting from zero).
So if your first value in that restarted sim is a 3, the running average would be 1.
This is fixed with this commit by setting WINDOW_START_ITER = RESTART_ITER in the Config Postprocessing,
if the option is not set. If the option is set, but incorrectly, an error is raised.
Related Work
Original implementation #836
Change in previous behavior introduced in #1548
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.