Proposed Changes

CSlidingInterface::GetDonor_Variable needs to access the Primitive of flow variables and the Solution of turbulent variables. Which one is the case, is currently decided by checking donor_solution->GetnPrimVar() == 2 (true->turbulent, false->flow). If the SA turbulence model is used, the non-overidden "virtual placeholder" CVariable::GetPrimitive(unsigned long,unsigned long) const returning zero is incorrectly called.

We propose to fix this by additionally checking for donor_solution->GetnPrimVar() == 1.

Related Work

@maxaehle, @mcmorelli, @BeckettZhou, @EduardoMolina

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
• My contribution is commented and consistent with SU2 style.
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.