Add unsteady cht adjoint testcase#1288
Merged
TobiKattmann merged 7 commits intodevelopfrom May 24, 2021
Merged
Conversation
|
This pull request introduces 1 alert when merging 3548413 into 7b1ad11 - view on LGTM.com new alerts:
|
TobiKattmann
commented
May 13, 2021
pcarruscag
reviewed
May 13, 2021
TestCases/coupled_cht/disc_adj_unsteadyCHT_cylinder/postprocess.py
Outdated
Show resolved
Hide resolved
pcarruscag
reviewed
May 13, 2021
TestCases/coupled_cht/disc_adj_unsteadyCHT_cylinder/chtMaster.cfg
Outdated
Show resolved
Hide resolved
TobiKattmann
commented
May 14, 2021
5 tasks
Contributor
Author
|
Code Factor complains about 2 things which are negligible imo. Good'ol complex code in CSolver which I didn't even touch and wildcard import of FADO things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added files
parallel_reg_AD will fail until the Testcases PR 63 is merged.
Related Work
Depends on #1260 and contains all of those changes (i.e. best reviewed after that is merged .. or just look at the last commit :) ). Meant to be merged shortly after but before #1284 to have an additional safeguarded case.
PR Checklist