Skip to content

Chore in CHeatSolver.cpp#1281

Merged
TobiKattmann merged 7 commits intodevelopfrom
chore_heatsolver
May 10, 2021
Merged

Chore in CHeatSolver.cpp#1281
TobiKattmann merged 7 commits intodevelopfrom
chore_heatsolver

Conversation

@TobiKattmann
Copy link
Contributor

@TobiKattmann TobiKattmann commented May 8, 2021

Proposed Changes

Cleanup CHeatSolver.cpp

  • define loop vars in the loop
  • make stuff const auto
  • remove unnecessary vars - or move definition&allocation where needed
  • some minor logical changes which hopefully are equivalent ( and therefore don't change the reg test 🤞 )
  • Fix primal unsteady Heat restarts

@oleburghardt might be interested in these changes ;)

Can be seen as a follow up to #1256 of @maxaehle (although I dont specifically fix memory leaks)

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • My contribution is commented and consistent with SU2 style.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

@TobiKattmann
Copy link
Contributor Author

TobiKattmann commented May 9, 2021

Fixed unsteady Heat restarts. Dotted blue line simulation runs trough and the solid blue is restarted (from the red ... which is identical to the dotted blue up to this point ... so it was kinda unnecessary 🤦 ).

The kink at the start is because of the same problem ... I just did a fresh restart with the solid blue i.e. if I would do a complete redo that kink wouldn't be there as well

before 4990753
imperfectUnsteadyCHTrestart
after
perfectUnsteadyCHTrestart

No I can go on with adjoints in #1260

@lgtm-com
Copy link

lgtm-com bot commented May 9, 2021

This pull request introduces 1 alert when merging 3c9861e into 2782983 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

@TobiKattmann
Copy link
Contributor Author

Merging this in now as the restart fix makes my life a bit easier in conjunction with #1260 . I am more than happy to address any comments, change requests etc after this was merged because this wasn't open very long tbh

@TobiKattmann TobiKattmann merged commit 7b1ad11 into develop May 10, 2021
@TobiKattmann TobiKattmann deleted the chore_heatsolver branch May 10, 2021 15:07
TobiKattmann added a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants