Fix inlet profile file loading when not restarting unsteady problems#1264
Merged
pcarruscag merged 5 commits intodevelopfrom Apr 20, 2021
Merged
Fix inlet profile file loading when not restarting unsteady problems#1264pcarruscag merged 5 commits intodevelopfrom
pcarruscag merged 5 commits intodevelopfrom
Conversation
Merged
5 tasks
bigfooted
reviewed
Apr 19, 2021
| config->GetKind_Solver() == DISC_ADJ_INC_RANS); | ||
|
|
||
| unsigned short nVar_Turb = 0; | ||
| if (turbulent) |
Contributor
There was a problem hiding this comment.
yes! Sanity checks should be (and are in this case) done in cconfig, so we can safely assume that the solver is a turbulence solver.
bigfooted
reviewed
Apr 19, 2021
|
This pull request introduces 3 alerts and fixes 2 when merging 3afaeef into bd5dde1 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 2 alerts when merging c3831fa into bd5dde1 - view on LGTM.com fixed alerts:
|
bigfooted
approved these changes
Apr 20, 2021
Contributor
bigfooted
left a comment
There was a problem hiding this comment.
Looks fine to me. Also like the introduction of the c++11 range based for loop. We should use that more often.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When not restarting unsteady problems, set file iteration to 0 (instead of the -1/-2 logic).
Related Work
https://www.cfd-online.com/Forums/su2/235485-parabolic-velocity-inlet-profile-error.html
PR Checklist