Conversation
|
@slnode test please |
|
To explain: this change is moving the two recently added test from top-level "end-to-end" block inside nested "empty-server template" block, where the sandbox app required by these two test cases is properly scaffolded by before/beforeEach hooks. /to @jannyHou @0candy please review |
|
The changes LGTM as you're just moving the test cases. However, CI is failing on that |
|
@slnode test please |
Move recently added tests for error-handling middleware into a describe block for empty-server template, to ensure the tests have a scaffolded app in the sandbox directory.
|
I have published My guess is that |
|
@slnode test please |
|
@0candy @jannyHou the remaining test failures seems to be intermittent. For example, cis-jenkins tests passed on all platforms, while pr-builder failed on Node v6 with errors that seem unrelated:
(see http://ci.strongloop.com/job/loopback-workspace/label=amazon-6/4378/) I am going to re-run CI again to see if we manage to get a green build. Even if not, I am proposing to merge this pull request, as it's a big step towards getting CI green. |
|
@slnode test please |
|
@bajtos LGTM and I think we can merge it now. The failing ones are downstream for apic and apim. |
Depends on strongloop/loopback-boot#194 and supersedes #294