Skip to content

Fix tests failing on CI#298

Merged
bajtos merged 1 commit intomasterfrom
fix/ci
Jul 14, 2016
Merged

Fix tests failing on CI#298
bajtos merged 1 commit intomasterfrom
fix/ci

Conversation

@bajtos
Copy link
Copy Markdown
Member

@bajtos bajtos commented Jun 28, 2016

Depends on strongloop/loopback-boot#194 and supersedes #294

@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 13, 2016

@slnode test please

@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 13, 2016

To explain: this change is moving the two recently added test from top-level "end-to-end" block inside nested "empty-server template" block, where the sandbox app required by these two test cases is properly scaffolded by before/beforeEach hooks.

/to @jannyHou @0candy please review
/cc @richardpringle @loay

@bajtos bajtos assigned jannyHou and 0candy and unassigned bajtos Jul 13, 2016
@0candy
Copy link
Copy Markdown
Contributor

0candy commented Jul 13, 2016

The changes LGTM as you're just moving the test cases. However, CI is failing on that end-to-end empty-server template test so it doesn't look like it is fixing the issue.

@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 14, 2016

@slnode test please

Move recently added tests for error-handling middleware into a describe
block for empty-server template, to ensure the tests have a scaffolded
app in the sandbox directory.
@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 14, 2016

I have published loopback-boot@2.20.0 to npmjs.org, that seems to have fixed the problem on my machine.

My guess is that npm install run from within the test suite uses the public npm registry, not the staging. @rmg is it something we can fix in our CI build tool? I would expect npm install executed by a test to use the same registry as npm install used to install the dependencies before running the tests.

@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 14, 2016

@slnode test please

@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 14, 2016

@0candy @jannyHou the remaining test failures seems to be intermittent. For example, cis-jenkins tests passed on all platforms, while pr-builder failed on Node v6 with errors that seem unrelated:

Test Result (5 failures / -3)
end-to-end autoupdate.end-to-end autoupdate before
end-to-end discovery.end-to-end discovery before
end-to-end testConnection.end-to-end testConnection before
end-to-end start/stop/restart.end-to-end start/stop/restart before
Middleware Middleware.create(def, cb).should be able to create multiple entries

(see http://ci.strongloop.com/job/loopback-workspace/label=amazon-6/4378/)

I am going to re-run CI again to see if we manage to get a green build. Even if not, I am proposing to merge this pull request, as it's a big step towards getting CI green.

@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 14, 2016

@slnode test please

@jannyHou
Copy link
Copy Markdown
Contributor

@bajtos LGTM and I think we can merge it now. The failing ones are downstream for apic and apim.
loopback-workspace also fails due to apic/apim failures.

@bajtos bajtos merged commit abf1a5b into master Jul 14, 2016
@bajtos bajtos deleted the fix/ci branch July 14, 2016 14:45
@bajtos bajtos removed the #review label Jul 14, 2016
@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Jul 14, 2016

Landed, thank you @0candy and @0candy for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants