Skip to content

update strong-error-handler test cases#294

Closed
loay wants to merge 1 commit intomasterfrom
handlertest
Closed

update strong-error-handler test cases#294
loay wants to merge 1 commit intomasterfrom
handlertest

Conversation

@loay
Copy link
Copy Markdown
Contributor

@loay loay commented Jun 24, 2016

No description provided.

@loay loay added the #review label Jun 24, 2016
@loay loay self-assigned this Jun 24, 2016
@loay loay closed this Jun 24, 2016
@loay loay removed the #review label Jun 24, 2016
@loay loay reopened this Jun 24, 2016
@loay loay added the #review label Jun 24, 2016
@loay loay force-pushed the handlertest branch 3 times, most recently from 464b540 to 86ea464 Compare June 27, 2016 17:00
@rmg
Copy link
Copy Markdown
Member

rmg commented Jun 27, 2016

@slnode test please

@rmg
Copy link
Copy Markdown
Member

rmg commented Jun 27, 2016

Now that I've got mysql in the test environment, the failures are being caused by eslint not being a dev dependency. The StrongLoop CI never saw this problem because posttest never gets triggered in that environment.

@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jun 27, 2016

@rmg Thanks for your help

@bajtos bajtos mentioned this pull request Jun 28, 2016
Merged
@bajtos
Copy link
Copy Markdown
Member

bajtos commented Jun 28, 2016

Now that I've got mysql in the test environment, the failures are being caused by eslint not being a dev dependency. The StrongLoop CI never saw this problem because posttest never gets triggered in that environment.

I opened a pull request to fix that, see #297

@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jun 28, 2016 •
edited
Loading

Some tests failing on PR #297 because of the issue (test cases) that I am addressing in this PR.
environments are overlapping so I separated them in this PR.
Can one of you review please: @bajtos or @0candy
Thanks.

@rmg
Copy link
Copy Markdown
Member

rmg commented Jun 28, 2016

@loay the commits in this PR are nice and small, which is great, but their commit messages aren't very helpful for figuring out why the change in each commit is being made.

@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jun 28, 2016

@rmg I was just trying to see if the fix I apply would work with jenkins. They were working fine locally but not on jenkins. I am squashing them anyways as they are irrelevant

@loay loay closed this Jun 29, 2016
@loay loay removed the #review label Jun 29, 2016
@loay loay reopened this Jun 29, 2016
@loay loay added the #review label Jun 29, 2016
@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jun 29, 2016

@slnode test please

@bajtos bajtos mentioned this pull request Jun 29, 2016
Merged
@bajtos bajtos mentioned this pull request Jul 13, 2016
Merged
@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jul 13, 2016

@slnode test please

@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jul 13, 2016

@slnode test please

2 similar comments
@rmg
Copy link
Copy Markdown
Member

rmg commented Jul 13, 2016

@slnode test please

@loay
Copy link
Copy Markdown
Contributor Author

loay commented Jul 13, 2016

@slnode test please

@bajtos
Copy link
Copy Markdown
Member

bajtos commented Jul 14, 2016

@loay as we discussed in Toronto, the test-cases for error handling should be grouped together in one place, as I am doing in #298. Let's close this pull request in favour of mine.

@bajtos bajtos closed this Jul 14, 2016
@bajtos bajtos removed the #review label Jul 14, 2016
@bajtos bajtos deleted the handlertest branch July 14, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bajtos bajtos

@loay loay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loay @rmg @bajtos