Save instructions.json in root dir#95
Save instructions.json in root dir#95bajtos merged 1 commit intostrongloop:masterfrom r3dm:fix/save-instruct-in-root
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Thank you for the pull request. The reason why we need to write the instructions to a file is that at the time of implementing the browserify feature, there was a bug browserify/browserify#771 which prevented us from using an in-memory stream. The bug should have been fixed in 5.x, thus we should be able to use a stream now - see the commented out code on L86-L92 of lib/bundler.js. Could you please upgrade browserify to the latest version and check if the stream-based solution works now? If it does, then I'd much rather drop the hack (writing the file) instead of trying to fix it. |
|
Just did a test run with Browserify 6.3 and it is working. Should I just amend this PR? |
Great!
Yes please. |
|
Should I also update devDep browserify version to latest? |
Update it to |
|
While I can confirm it gives me the correct compile in my app, I can't get two tests (browser.test.js fails while all other test are green) to pass using stream method. It seems to hang waiting for browserify to close the pipe. Can't see why, but my knowledge of pipes here is lacking. How should I proceed? |
|
I don't have time now to investigate this myself. Let's stick to the workaround solution we have now then. |
lib/bundler.js
Outdated
There was a problem hiding this comment.
I am little bit worried about adding a generated file that looks like it is a part of loopback-boot sources. Can we use a different name that would make it clear that the file is a temporary artefact created during the build? Few suggestions: .generated-instructions.js or .browser.instructions.js.
Saving in node_modules dir causes complaints and missing files fixes #94
|
@bajtos file now saving as generated-instructions.json |
Save instructions.json in root dir
|
Landed, thank you! |
|
Released as |
Saving instructions in node_modules dir causes complaints and missing files
fixes #94