Skip to content

Change test cases port to be dynamic#205

Merged
davidcheung merged 1 commit intomasterfrom
indepdent-port
Aug 16, 2016
Merged

Change test cases port to be dynamic#205
davidcheung merged 1 commit intomasterfrom
indepdent-port

Conversation

@davidcheung
Copy link
Copy Markdown
Contributor

connect to #197

@davidcheung davidcheung added this to the #Epic: CI cleanup milestone Aug 11, 2016
@davidcheung davidcheung self-assigned this Aug 11, 2016
@davidcheung
Copy link
Copy Markdown
Contributor Author

@slnode test please

1 similar comment
@davidcheung
Copy link
Copy Markdown
Contributor Author

@slnode test please

To avoid port collision when running in Jenkins
@davidcheung
Copy link
Copy Markdown
Contributor Author

@gunjpan PTAL

@davidcheung davidcheung assigned gunjpan and unassigned davidcheung Aug 16, 2016
@gunjpan
Copy link
Copy Markdown
Contributor

gunjpan commented Aug 16, 2016

@davidcheung : Does that pass on local? changes seems trivial to me.
LGTM. See if you can resolve CI failures (they're mostly timeout related though)

@davidcheung
Copy link
Copy Markdown
Contributor Author

@gunjpan yes it passes on local

@davidcheung davidcheung merged commit e68502a into master Aug 16, 2016
@davidcheung davidcheung deleted the indepdent-port branch August 16, 2016 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants