remove v2-specific guards for removing nils from request params#1816
Merged
xavdid-stripe merged 1 commit intomasterfrom Mar 17, 2026
Merged
remove v2-specific guards for removing nils from request params#1816xavdid-stripe merged 1 commit intomasterfrom
xavdid-stripe merged 1 commit intomasterfrom
Conversation
mbroshi-stripe
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
In #1796, we fixed a bug where values that defaulted to
nilwere erroneously sent to the server in v2 requests. At the time, we restricted these new checks to v2 requests because V1 requests already handled this correctly (nilis ignored in request params). For simplicity, we're removing the v2-specific checks and using the same approach for all request params. This shouldn't be a user-facing change.What?
RequestParmsvalue trackingSee Also