Ignore unset properties of V2 Request param classes when making requests#1796
Merged
prathmesh-stripe merged 5 commits intomasterfrom Feb 23, 2026
Merged
Conversation
d1d550d to
1e08101
Compare
Contributor
Author
|
Ensure that |
xavdid-stripe
approved these changes
Feb 23, 2026
xavdid-stripe
pushed a commit
that referenced
this pull request
Feb 23, 2026
…sts (#1796) * Add some tests * Fixed V2 request param serialization of unset parameters * Added a test case for updating a property after initialization --------- Co-authored-by: Michael Broshi <mbroshi@stripe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We recently changed behavior of V2 requests in #1788 , #1786 and #1758.
When passing in typed param classes to requests all the properties are set as nil. In V2 this becomes a problem because the backend can accept null value as valid input.
In V1, these null values are removed before being sent to the API which works as expected.
What?
_explicitly_set_keysvar.See Also
https://jira.corp.stripe.com/browse/RUN_DEVSDK-2239