Skip to content

Make native 3ds translucent#13146

Merged
amk-stripe merged 3 commits into
masterfrom
make-native-3ds2-transparent
May 26, 2026
Merged

Make native 3ds translucent#13146
amk-stripe merged 3 commits into
masterfrom
make-native-3ds2-transparent

Conversation

@amk-stripe

@amk-stripe amk-stripe commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Make native 3ds translucent

Motivation

https://jira.corp.stripe.com/browse/RUN_MOBILESDK-5390

Testing

  • Added tests
  • Modified tests
  • Manually verified

Added log statement to onStop of PaymentSheetPlaygroundActivity. Prior to this change, onStop was called when you entered the 3ds2 flow. After this change, it's not called.

Test cards for native 3ds flow are here.

Screenshots

Before After
before screenshot after screenshot

Changelog

  • [FIXED]13146 Native 3ds2 no longer stops its host activity

@github-actions

github-actions Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   4.6 MiB │   4.6 MiB │   +3 B │   9.7 MiB │   9.7 MiB │    0 B 
     arsc │   3.8 MiB │   3.8 MiB │ +124 B │   3.8 MiB │   3.8 MiB │ +124 B 
 manifest │   5.8 KiB │   5.8 KiB │   +4 B │  30.8 KiB │  30.8 KiB │    0 B 
      res │     1 MiB │     1 MiB │   +3 B │   1.7 MiB │   1.7 MiB │    0 B 
   native │   2.7 MiB │   2.7 MiB │    0 B │   2.7 MiB │   2.7 MiB │    0 B 
    asset │  23.5 KiB │  23.5 KiB │   -1 B │  44.2 KiB │  44.2 KiB │   -1 B 
    other │ 245.4 KiB │ 245.4 KiB │   +9 B │ 505.1 KiB │ 505.1 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.3 MiB │  12.3 MiB │ +142 B │  18.4 MiB │  18.4 MiB │ +123 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 45274 │ 45274 │ 0 (+1 -1) 
   types │ 14272 │ 14272 │ 0 (+0 -0) 
 classes │ 11594 │ 11594 │ 0 (+0 -0) 
 methods │ 63368 │ 63368 │ 0 (+0 -0) 
  fields │ 41155 │ 41155 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  319 │  319 │  0         
 entries │ 7475 │ 7476 │ +1 (+1 -0)
APK 
    compressed     │    uncompressed    │                               
──────────┬────────┼───────────┬────────┤                               
 size     │ diff   │ size      │ diff   │ path                          
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.8 MiB │ +124 B │   3.8 MiB │ +124 B │ ∆ resources.arsc              
 55.6 KiB │  +11 B │ 130.6 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
  5.8 KiB │   +4 B │  30.8 KiB │    0 B │ ∆ AndroidManifest.xml         
  4.6 MiB │   +3 B │   9.7 MiB │    0 B │ ∆ classes.dex                 
 58.9 KiB │   -3 B │ 130.6 KiB │    0 B │ ∆ META-INF/CERT.SF            
  7.4 KiB │   -1 B │   7.2 KiB │   -1 B │ ∆ assets/dexopt/baseline.prof 
    764 B │   +1 B │   1.4 KiB │    0 B │ ∆ res/AB.xml                  
  1.1 KiB │   +1 B │   3.4 KiB │    0 B │ ∆ res/B7.xml                  
    557 B │   +1 B │     908 B │    0 B │ ∆ res/PV.xml                  
    709 B │   -1 B │   1.3 KiB │    0 B │ ∆ res/QN.xml                  
    581 B │   -1 B │     1 KiB │    0 B │ ∆ res/S8.xml                  
    634 B │   +1 B │   1.2 KiB │    0 B │ ∆ res/a0.xml                  
    687 B │   +1 B │   1.3 KiB │    0 B │ ∆ res/hR.xml                  
  1.2 KiB │   +1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
──────────┼────────┼───────────┼────────┼───────────────────────────────
  8.5 MiB │ +142 B │  13.8 MiB │ +123 B │ (total)
MANIFEST 
@@ -323,3 +323,3 @@
         android:name="com.stripe.android.payments.core.authentication.threeds2.Stripe3ds2TransactionActivity"
-        android:theme="@style/StripeDefaultTheme"
+        android:theme="@style/Stripe3dsTransactionTheme"
         />
DEX 
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   45274 │ 45274 │ 0 (+1 -1) 
  
  +  to 2, 2132083231
  
  -  to 2, 2132083230
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   7475 │ 7476 │ +1 (+1 -0) 
  + style/Stripe3dsTransactionTheme

@amk-stripe amk-stripe marked this pull request as ready for review May 22, 2026 23:40
@amk-stripe amk-stripe requested review from a team as code owners May 22, 2026 23:40
@amk-stripe amk-stripe requested a review from samer-stripe May 22, 2026 23:40
samer-stripe
samer-stripe previously approved these changes May 25, 2026
View reviewed changes
@amk-stripe amk-stripe enabled auto-merge (squash) May 26, 2026 16:34
@amk-stripe amk-stripe merged commit a746bac into master May 26, 2026
53 checks passed
@amk-stripe amk-stripe deleted the make-native-3ds2-transparent branch May 26, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samer-stripe samer-stripe samer-stripe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amk-stripe @samer-stripe