fix(google pay): additionalEnabledNetworks is ignored in one constructor#12983
Merged
jaynewstrom-stripe merged 2 commits intoMay 5, 2026
Merged
Conversation
|
|
|
|
b21ad2c to
cbdc4f0
Compare
jaynewstrom-stripe
approved these changes
May 5, 2026
Collaborator
|
Thanks! I'm going to follow up with a PR to move the changelog entry, but otherwise looks good to me! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additionalEnabledNetworksis never passed from the public to the internal constructorThis is used by
GooglePayButtonwhich ultimately reads this value from the Google Pay config.Motivation
It would be helpful to actually use the config options API users can provide.
Testing
Changelog
additionalEnabledNetworkswould not be respected for Google Pay payments.