assert.Len: use %v when formatting value#1086
Closed
benjaminjkraft wants to merge 1 commit intostretchr:masterfrom
Closed
assert.Len: use %v when formatting value#1086benjaminjkraft wants to merge 1 commit intostretchr:masterfrom
benjaminjkraft wants to merge 1 commit intostretchr:masterfrom
Conversation
It was using %s, which doesn't work if the thing being len'ed is not a
`[]string` or similar. For example, `assert.Len(t, []int{1}, 0)` says
that `[%!s(int=1)] should have 1 item(s), but has 0`. Now it uses `%v`
which will work for almost anything.
k1ng440
approved these changes
Jul 16, 2021
vaguecoder
added a commit
to vaguecoder/testify
that referenced
this pull request
Jul 17, 2022
vaguecoder
added a commit
to vaguecoder/testify
that referenced
this pull request
Jul 17, 2022
wwade
reviewed
Nov 29, 2022
Contributor
wwade
left a comment
There was a problem hiding this comment.
Looks good and matches the change I was planning to make 😄
Contributor
|
@glesica @boyan-soubachov @mvdkleijn could someone please have a look at this one? |
Collaborator
|
@benjaminjkraft @k1ng440 @wwade Could you instead review #1485 which I plan to merge soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
assert.Len's error message for non-%sable values.Details
It was using %s, which doesn't work if the thing being len'ed is not a
[]stringor similar. For example,assert.Len(t, []int{1}, 0)saysthat
[%!s(int=1)] should have 1 item(s), but has 0. Now it uses%vwhich will work for almost anything.