Skip to content

fix: Fix TestUpdateTopicNotExist and TestUpdateNonPartitionedTopic#1067

Merged
RobertIndie merged 1 commit into
masterfrom
fix-TestUpdateTopicNotExist
May 16, 2023
Merged

fix: Fix TestUpdateTopicNotExist and TestUpdateNonPartitionedTopic#1067
RobertIndie merged 1 commit into
masterfrom
fix-TestUpdateTopicNotExist

Conversation

@RobertIndie

@RobertIndie RobertIndie commented May 16, 2023

Copy link
Copy Markdown
Member

Motivation

There is two failed tests when using Pulsar 3.0.0:

=== RUN   TestUpdateTopicNotExist
    update_test.go:85: 
        	Error Trace:	/pulsarctl/pkg/ctl/topic/update_test.go:85
        	Error:      	Not equal: 
        	            	expected: "code: 409 reason: Topic is not partitioned topic"
        	            	actual  : "code: 409 reason: Topic persistent://public/default/non-exist-topic is not the partitioned topic."
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-code: 409 reason: Topic is not partitioned topic
        	            	+code: 409 reason: Topic persistent://public/default/non-exist-topic is not the partitioned topic.
        	Test:       	TestUpdateTopicNotExist
--- FAIL: TestUpdateTopicNotExist (0.01s)
=== RUN   TestUpdateNonPartitionedTopic
    update_test.go:96: 
        	Error Trace:	/pulsarctl/pkg/ctl/topic/update_test.go:96
        	Error:      	Not equal: 
        	            	expected: "code: 409 reason: Topic is not partitioned topic"
        	            	actual  : "code: 409 reason: Topic persistent://public/default/test-update-non-partitioned-topic is not the partitioned topic."
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-code: 409 reason: Topic is not partitioned topic
        	            	+code: 409 reason: Topic persistent://public/default/test-update-non-partitioned-topic is not the partitioned topic.
        	Test:       	TestUpdateNonPartitionedTopic
--- FAIL: TestUpdateNonPartitionedTopic (0.02s)

More details in https://github.com/streamnative/pulsarctl/actions/runs/4976702208/jobs/8905382299?pr=1064#step:3:1349

This is because we change the log message in Pulsar 3.0.0 by this PR: apache/pulsar#19166

Modifications

  • Fix the assert of the test

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@RobertIndie RobertIndie self-assigned this May 16, 2023
@github-actions github-actions Bot added the no-need-doc This pr does not need any document label May 16, 2023
@RobertIndie RobertIndie merged commit 11a3e8f into master May 16, 2023
@RobertIndie RobertIndie deleted the fix-TestUpdateTopicNotExist branch May 16, 2023 08:02
RobertIndie added a commit that referenced this pull request May 16, 2023
…1067)

### Motivation

There is two failed tests when using Pulsar 3.0.0:
```
=== RUN   TestUpdateTopicNotExist
    update_test.go:85:
        	Error Trace:	/pulsarctl/pkg/ctl/topic/update_test.go:85
        	Error:      	Not equal:
        	            	expected: "code: 409 reason: Topic is not partitioned topic"
        	            	actual  : "code: 409 reason: Topic persistent://public/default/non-exist-topic is not the partitioned topic."

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-code: 409 reason: Topic is not partitioned topic
        	            	+code: 409 reason: Topic persistent://public/default/non-exist-topic is not the partitioned topic.
        	Test:       	TestUpdateTopicNotExist
--- FAIL: TestUpdateTopicNotExist (0.01s)
=== RUN   TestUpdateNonPartitionedTopic
    update_test.go:96:
        	Error Trace:	/pulsarctl/pkg/ctl/topic/update_test.go:96
        	Error:      	Not equal:
        	            	expected: "code: 409 reason: Topic is not partitioned topic"
        	            	actual  : "code: 409 reason: Topic persistent://public/default/test-update-non-partitioned-topic is not the partitioned topic."

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-code: 409 reason: Topic is not partitioned topic
        	            	+code: 409 reason: Topic persistent://public/default/test-update-non-partitioned-topic is not the partitioned topic.
        	Test:       	TestUpdateNonPartitionedTopic
--- FAIL: TestUpdateNonPartitionedTopic (0.02s)
```

More details in https://github.com/streamnative/pulsarctl/actions/runs/4976702208/jobs/8905382299?pr=1064#step:3:1349

This is because we change the log message in Pulsar 3.0.0 by this PR: apache/pulsar#19166

### Modifications

* Fix the assert of the test

(cherry picked from commit 11a3e8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-need-doc This pr does not need any document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants