Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Conversation

@BewareMyPower
Copy link
Collaborator

There're some code and configs from a long time ago. They're unused now and may cause confusion. For example, we should document KoP config items in docs/configuration.md instead of kafka-impl/conf/kop.conf.

@BewareMyPower BewareMyPower force-pushed the bewaremypower/delete-unused-files branch from ed3cacb to bff0e70 Compare February 26, 2021 10:52
@BewareMyPower
Copy link
Collaborator Author

@jiazhai PTAL

@jiazhai jiazhai merged commit 783067c into streamnative:master Mar 3, 2021
@BewareMyPower BewareMyPower deleted the bewaremypower/delete-unused-files branch March 10, 2021 09:07
BewareMyPower added a commit that referenced this pull request Jul 6, 2021
This PR migrates #404 #570 and because it's too hard to cherry-pick them.

In addition, since Pulsar 2.7.2.6 introduced API changes but it only affected some unused classes that were removed from master branch in #387, this PR removed them so that KoP 2.7.2.6 can keep compatible with Pulsar 2.7.0.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants