Add MetricsEvent proto & Fivetran infrastructure
#9695
Merged
+402
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
approved these changes
Oct 23, 2024
Collaborator
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 Added one general question related tot the event structure
| string label = 22; | ||
|
|
||
|
|
||
| // Page Profile Event fields: |
Collaborator
There was a problem hiding this comment.
Do we need to keep this a flat structure? If nesting is fine we could potentially use an oneof here to have a better separation between the different event types, e.g.:
oneof metadata {
PageProfile page_profile = 1;
MenuClick menu_click = 2;In that case, we could potentially also reuse the existing page profile message by moving all the frontend added fields into it as well.
Collaborator
Author
There was a problem hiding this comment.
I had same thought, but then DS confirmed during testing its much easier to work with in flat structure (Fivetran does not auto-flatten the same way Segment did) so they strongly preferred this version
mayagbarnes
added a commit
that referenced
this pull request
Oct 24, 2024
**Metrics Migration Part 2:** This PR adds a `MetricsEvent` proto for a single source of truth for event fields, as well as the infrastructure necessary to send event data to the testing Fivetran webhook in parallel with Segment. This includes building the `anonymousId` & `context` data fields for FW that we received by default from Segment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Metrics Migration Part 2: This PR adds a
MetricsEventproto for a single source of truth for event fields, as well as the infrastructure necessary to send event data to the testing Fivetran webhook in parallel with Segment. This includes building theanonymousId&contextdata fields for FW that we received by default from Segment.Testing Plan
See demo app here & metrics comparison app here