Fixing MultiSelect flaky test #719
Conversation
|
Options hidden/cutoff when many are selected because input does not expand
|
Thanks for the catch @jrhone !, fixed using minHeight instead of height |
frontend/src/lib/widgetTheme.ts
Outdated
| export const multiSelectOverrides = { | ||
| ValueContainer: { | ||
| style: () => ({ | ||
| minHeight: "44px", // Fixing minimum height in order to prevent some changing height |
There was a problem hiding this comment.
Hmm... this does fix it, but it feels a bit hacky.
Any idea what is causing BaseWeb to misbehave? I can't repro the bug in the BaseWeb page https://v8-17-1.baseweb.design/components/select/ , but when I remove all theming from widgetTheme.ts, I can still repro the bug. So my guess is our other styles are interfering with BaseWeb. I just can't figure out which styles are to blame.
It would be nice to figure out the source of this bug, so it can be fixed in a more future-proof manner.
If you spend a couple of hours on this and still can't find the underlying cause, feel free to merge this version. But please add a comment explaining whatever you found out, and link it to the original bug.
There was a problem hiding this comment.
I've tested it using the example from their documentation and it's doing the same, look at this:
… 590/MultiSelectWalksAfterSelecting
* develop: Fix Python tests on Mac (streamlit#786) Fixing MultiSelect flaky test (streamlit#719) Checking allowed file extensions (streamlit#761) Fixing Graphviz tests (streamlit#750)
Issue: This PR Fixes #590
Description: Fixing height for values container to prevent page walk
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.