Remove stale comments and group statements writing to protobufs #7093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2919a19 to
e18bf8c
Compare
asmeralt
pushed a commit
to asmeralt/streamlit
that referenced
this pull request
Sep 29, 2025
…amlit#7093) Now that we've merged streamlit#7003, some of the comments we have about when certain fields are written to widget protos are now stale. While removing these comments, we also move a few lines around so that lines where we're writing to widget protobufs are grouped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've merged #7003, some of the comments we have about when certain
fields are written to widget protos are now stale. While removing these comments, we also
move a few lines around so that lines where we're writing to widget protobufs are grouped.