Fix protobuf gen in min deps workflow #6909
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should ensure we have the needed mypy proto package installed. Don't know how it passed previously.
tconkling
approved these changes
Jun 27, 2023
mayagbarnes
approved these changes
Jun 27, 2023
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jun 27, 2023
* develop: Fix protobuf gen in min deps workflow (streamlit#6909)
asmeralt
pushed a commit
to asmeralt/streamlit
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the package install to before proto generation should ensure we have the needed mypy proto package installed. Don't know how it passed previously.
Testing Plan
CI change
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.