Skip to content

Conversation

@sfc-gh-kbregula
Copy link
Contributor

Describe your changes

If the variables are set in the workflow.yaml file, then we should no longer change them via the script.

# We don't want to use constraints files because they might not exist yet.
USE_CONSTRAINT_FILE: "false"

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-kbregula sfc-gh-kbregula force-pushed the constraints-files-release branch from 9ae8460 to 5eb3b29 Compare June 27, 2023 07:19
@sfc-gh-kbregula sfc-gh-kbregula marked this pull request as draft June 27, 2023 11:29
@sfc-gh-kbregula sfc-gh-kbregula added change:chore PR contains maintenance or housekeeping change impact:internal PR changes only affect internal code labels Jun 27, 2023
@sfc-gh-kbregula sfc-gh-kbregula marked this pull request as ready for review July 7, 2023 18:33
@sfc-gh-kbregula sfc-gh-kbregula added the security-assessment-completed Security assessment has been completed for PR label Jul 10, 2023
@sfc-gh-kbregula sfc-gh-kbregula force-pushed the constraints-files-release branch from 0e20e16 to 4399e65 Compare July 10, 2023 08:31
@sfc-gh-kbregula sfc-gh-kbregula merged commit 2a9353c into develop Jul 10, 2023
tconkling added a commit to tconkling/streamlit that referenced this pull request Jul 10, 2023
* develop:
  Respect current existing env var in build_info.py (streamlit#6906)
  fix: frontend/package.json & frontend/yarn.lock to reduce vulnerabilities (streamlit#6959)
  Update hamburger menu icon to overflow (streamlit#6947)
  Fix: description of config options (streamlit#6917)
  Add missing border radius (streamlit#6944)
  Up version to 1.24.0 (streamlit#6905)
  modify st.echo to use ast to handle indenting properly (streamlit#5375)
@vdonato vdonato deleted the constraints-files-release branch November 1, 2023 23:57
asmeralt pushed a commit to asmeralt/streamlit that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:chore PR contains maintenance or housekeeping change impact:internal PR changes only affect internal code security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants