Add host communication e2e tests #6806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab9ee47 to
648ef96
Compare
Collaborator
Author
|
Hi @sfc-gh-hpathak 😃 |
4a74c90 to
33fafdb
Compare
vdonato
approved these changes
Jun 27, 2023
d440f63 to
f770816
Compare
f770816 to
fc7fb32
Compare
vdonato
approved these changes
Jul 7, 2023
Collaborator
vdonato
left a comment
There was a problem hiding this comment.
Some small nits, but aside from those LGTM!
Will have the RA reviewed by EOD today
Collaborator
Author
|
For documentation, applicable RA link here |
sfc-gh-hpathak
approved these changes
Jul 11, 2023
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jul 12, 2023
* develop: Feature: st.toast (streamlit#6783) Bump semver from 5.7.1 to 5.7.2 in /frontend (streamlit#6982) Add host communication e2e tests (streamlit#6806) Re-add homepage to package.json (streamlit#6987) Remove unnecessary code and Add rm commands to make clean (streamlit#6980) Allow setting placeholder for st.selectbox (streamlit#6913) Allow setting placeholder for st.multiselect (streamlit#6901) Also use bottom padding in embedded mode for chat input (streamlit#6979) Feature/st lib (streamlit#6692) Remove unused import (streamlit#6977) Release 1.24.1 (streamlit#6965) Update st.audio/st.video docstrings (streamlit#6964) Slightly simplify bug report template (streamlit#6972) Fix baseweb warnings by using longhand properties (streamlit#6976)
asmeralt
pushed a commit
to asmeralt/streamlit
that referenced
this pull request
Sep 29, 2025
Adding Cypress end to end tests for host <-> guest communication, based on the recently refactored HostCommunicationManager. Previously, we used hostframe.html to manually test sending messages from the host frame and their processing. This PR allows our automated Github Action workflow for Cypress e2e tests to test this functionality by: whitelisting localhost as an allowed origin - ONLY in development mode & adding a script/spec to trigger messages from a host frame & check for their results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding Cypress end to end tests for host <-> guest communication, based on the recently refactored
HostCommunicationManager.Previously, we used
hostframe.htmlto manually test sending messages from the host frame and their processing. This PR allows our automated Github Action workflow for Cypress e2e tests to test this functionality by:localhostas an allowed origin - ONLY in development mode