Minimum version dependency testing #6802
Conversation
Remove use of certain recent type annotations
This was causing us to install the "install" package
| # This section is an inlined copy of the make_init action | ||
| # Both because we need to do some parts of it differently | ||
| # and because it running in a separate action causes the python path | ||
| # setup to work weirdly, so some tests fail unless you run an install | ||
| # command in the workflow directly. |
There was a problem hiding this comment.
You may have already experimented with this, but just to confirm - adding a new input flag to the make_init action to handle the differences below doesn't work?
List of those I could identify:
- creating the Python environment cache key (lib/min-constraints-gen.txt vs. lib/dev-requirements.txt)
- restore virtualenv from cache (changed key name)
- Create Virtual Env (make python-init-test-min-deps vs. make python-init)
There was a problem hiding this comment.
I didn't try doing it as a new input flag, because it felt like it would result in a bad abstraction. While prototyping this, I made changes to make_init directly, and then when I discovered that the path only gets set up correctly if you do an additional install command in the workflow (the existing test workflows do make develop in a step after the make_init action), I decided to inline the action's steps.
Possibly we should just delete that part of the test
Outside of the venv setup block
tconkling
left a comment
There was a problem hiding this comment.
This is great!
As-is, it looks like min-constraints-gen.txt can get stale without us knowing. I don't think this needs to block the PR, but we may want to follow this PR with a CI change that runs make gen-min-dep-constraints in CI and errors if the output is different from the committed file. (We do this with the NOTICES file in the "Validate NOTICES" job in js-tests.yml)
| urllib3>=1.9 | ||
|
|
||
| hypothesis>=6.17.4 | ||
| parameterized | ||
| pytest | ||
| pytest-cov | ||
| requests-mock | ||
| testfixtures | ||
|
|
||
|
|
||
| mypy-protobuf>=3.2 | ||
|
|
There was a problem hiding this comment.
Nit: I think the convention here is to alphabetize all dependencies in the list (and also no extra newlines).
Re: the new requirements themselves - it looks like most of these are duplicated from dev-requirements.txt. Should we just be installing dev-requirements.txt for this set of tests, rather than duplicating? Or does that break something with min-dependency testing?
(If the latter, can we add documentation to test-requirements.txt explaining the duplication?)
There was a problem hiding this comment.
Some dev requirements (mainly black) would impose much higher minimum versions of dependencies we share with them, which I wanted to avoid.
There was a problem hiding this comment.
Possibly some of these should be factored out into a 3rd requirements file
There was a problem hiding this comment.
It's also possible that we don't mind requiring a more recent typing extensions version, or could roll back to an older version of black that doesn't need something so recent (don't remember why we're on the version we have).
* develop: Minimum version dependency testing (streamlit#6802) Delay slider `thumbValueAlignment` to allow page layout to complete (streamlit#6828)
Describe your changes
Updates to the minimum versions of many dependencies, along with a script for generating a constraints file that can be used to install the minimum versions to run tests against.
Testing Plan
These are changes to our dependency version constraints, and testing infrastructure.