Skip to content

Conversation

@Ashad001
Copy link
Contributor

@Ashad001 Ashad001 commented Jun 2, 2023

📚 Context

Please describe the project or issue background here

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Readme update

🧠 Description of Changes

  • Add bullet points summarizing your changes here

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

Insert screenshot of your updated UI/code here
image
linked documentations pages of relevant images

Input widgets
Dataframes
Charts
Layout
Multipage apps
Fun : linked to gallery

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

🌐 References

Does this depend on other work, documents, or tickets?

  • Issue: Closes #XXXX

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes self-assigned this Jun 2, 2023
@mayagbarnes
Copy link
Collaborator

@snehankekre -> Makes sense to me to have these elements link to relevant docs, but would appreciate your perspective 😃

@mayagbarnes mayagbarnes changed the title doc updated README.md updated with links to docs Jun 2, 2023
@mayagbarnes
Copy link
Collaborator

Hi @Ashad001, thanks for your contribution to Streamlit! 🎈
Going to have my colleague Snehan take a quick look and proceed from there.

@Ashad001 Ashad001 requested a review from mayagbarnes June 5, 2023 01:42
@mayagbarnes mayagbarnes added the security-assessment-completed Security assessment has been completed for PR label Jun 5, 2023
@mayagbarnes mayagbarnes merged commit ee035a3 into streamlit:develop Jun 5, 2023
tconkling added a commit to tconkling/streamlit that referenced this pull request Jun 6, 2023
* develop:
  Remove tensorflow and pytorch from test requirements (streamlit#6807)
  Fix readme links (streamlit#6800)
  Update PR template to be simpler and more approachable (streamlit#6679)
  README updated with links to docs (streamlit#6780)
  Refactor: withHostCommunication -> HostCommunicationManager (streamlit#6746)
  Add python 3.11 to classifiers list. (streamlit#6786)
  Release/1.23.1 (streamlit#6777)
  We depend on typing-extensions 4.0.1 (streamlit#6776)
  Release/1.23.0 (streamlit#6773)
  Fix typo in data_editor docstring and deprecation msg: `edited_rows` -> `edited_cells` (streamlit#6770)
  Fix: Remove flaky date input calendar snapshot test (streamlit#6769)
  Fix 3218, patch pydantic in_ipython function (streamlit#6664)
  Upgrade react-range to fix memory usage of sliders (streamlit#6764)
  Make st.write pretty-print dataclasses using st.help (streamlit#6750)
  Replace curly with straightquotes in docstring examples (streamlit#6757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants