Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Apr 21, 2023

📚 Context

This implements some of the suggestions from #6066 to improve the startup performance of Streamlit:

  1. Move Styler imports to function-level
  2. Move requests imports to function-level
  3. Move validators library to function-level
  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@lukasmasuch lukasmasuch changed the title Improve startup performance [WIP] Improve startup performance May 3, 2023
@lukasmasuch lukasmasuch marked this pull request as ready for review May 23, 2023 19:22
@lukasmasuch lukasmasuch added the security-assessment-completed Security assessment has been completed for PR label May 23, 2023
@lukasmasuch lukasmasuch changed the title [WIP] Improve startup performance Use lazy loading for some dependencies for better startup performance May 23, 2023
@lukasmasuch lukasmasuch changed the title Use lazy loading for some dependencies for better startup performance Improve startup performance by lazy loading some dependencies May 23, 2023
@lukasmasuch lukasmasuch merged commit 3f890f5 into develop May 23, 2023
tconkling added a commit to tconkling/streamlit that referenced this pull request May 30, 2023
* develop: (22 commits)
  enzyme -> react-testing-library (Countdown, Modal, ProgressBar) (streamlit#6744)
  Remove console.log (streamlit#6753)
  Update `st.data_editor` and `st.dataframe` docstrings (streamlit#6752)
  Update `st.data_editor` session state format (streamlit#6711)
  Cypress flaky test fixes (streamlit#6743)
  Document integer size limit for number_input and slider (streamlit#6724)
  Change default theme hash on app init (streamlit#6729)
  Use .genericFonts instead of .fonts to fix bug with theme postMessage. (streamlit#6732)
  Improve startup performance by lazy loading some dependencies (streamlit#6531)
  Add support for Altair 5 (streamlit#6618)
  Update modals (streamlit#6688)
  Improve docstrings for `ttl` and `max_entries` (streamlit#6733)
  Improve `st.columns` docstring (streamlit#6727)
  Removed orphan line in dataframe docstring (streamlit#6734)
  Fix useIsOverflowing dependency array (streamlit#6731)
  Remove experimental from data editor (streamlit#6712)
  Clarify set_page_config docstring and exception message (streamlit#6594)
  Add a config option to disable warning for setting both a widget default and its key in session_state (streamlit#6640)
  Add column configuration API for `st.dataframe` and `st.data_editor` (streamlit#6598)
  Migrate datetime column formatting from date-fns to momentJS (streamlit#6702)
  ...
@vdonato vdonato deleted the fix/styler-imports branch November 1, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants