Misc st.experimental_connection fixes omnibus #6523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c35b223 to
ee35111
Compare
ee35111 to
d8aaa3e
Compare
lukasmasuch
approved these changes
Apr 20, 2023
| ) | ||
| @cache_data(ttl=ttl) | ||
| @cache_data( | ||
| show_spinner="Running `SQL.query(...)`.", |
Collaborator
There was a problem hiding this comment.
nit: maybe sql.query(...) would be slightly better here since it's more likely to be something called on an instance, and the lowercase version also corresponds better to the connection name.
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Add missing default arg * Error when tenacity is not installed on connection creation * Add more missing module -> PyPI package mappings * Change spinner messages for .query() methods to hide internals * Complain more clearly if no SQL connection params at all are set * Support named snowsql config file sections * Remove unneeded f-string * Raise exception when no Snowpark config is set * Use correct mysql PyPI package name * Make query method spinner messages lowercase
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Add missing default arg * Error when tenacity is not installed on connection creation * Add more missing module -> PyPI package mappings * Change spinner messages for .query() methods to hide internals * Complain more clearly if no SQL connection params at all are set * Support named snowsql config file sections * Remove unneeded f-string * Raise exception when no Snowpark config is set * Use correct mysql PyPI package name * Make query method spinner messages lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of tiny fixes that came out of testing
st.experimental_connectionthatare small enough that it's not worth the overhead of making individual PRs for.
This PR batches these changes. Note it's easiest to review this commit-by-commit.