Don't always retry on .query() errors for SQL and Snowpark connections #6511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1b48d9 to
ce59499
Compare
2f2aede to
81c8c17
Compare
ce59499 to
9b9acce
Compare
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
#6511) * Don't always retry for Snowpark connection * Don't always retry for SQL connection
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
#6511) * Don't always retry for Snowpark connection * Don't always retry for SQL connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
I initially implemented the retry logic for the
.query()method of both theSQLandSnowparkconnections to always retry regardless of the exception type, which isn't great because tons of
exceptions are due to non-transient errors that won't go away just by trying again. This PR restricts
the exception types that we retry on for both connections.