Use the current active Snowpark session if one is available #6504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a0b89c to
e684760
Compare
d979553 to
73b3c87
Compare
lukasmasuch
approved these changes
Apr 19, 2023
| # available, we just use that one. Otherwise, we fall back to attempting to | ||
| # create a new one from whatever credentials we have available. | ||
| try: | ||
| return get_active_session() |
Collaborator
There was a problem hiding this comment.
Is there a situation where the session returned by get_active_session is actually not what the user is trying to connect to? E.g. if the user is logged in with a certain account/role, but actually wants to use a different one?
Collaborator
Author
There was a problem hiding this comment.
Not as far as I understand -- @sfc-gh-jcarroll might know if there's any weirdness that can go on here, though
Contributor
There was a problem hiding this comment.
I'm not aware of any either, I think this will work. Might be worth tagging Yijun on the main PR to look at the Snowpark connection all up for any concerns like this?
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
* Use the current active Snowpark session if one is available * Only run Snowpark tests in Snowflake CI tests * Add `type: ignore`s
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Use the current active Snowpark session if one is available * Only run Snowpark tests in Snowflake CI tests * Add `type: ignore`s
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Use the current active Snowpark session if one is available * Only run Snowpark tests in Snowflake CI tests * Add `type: ignore`s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This one's pretty self-explanatory. In some runtime environments, we'll already have an active
Snowpark session available (grabbing it is easy thanks to the Snowpark library's
get_active_sessionfunction). We just want to use this active session when possible.