Skip to content

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented Apr 13, 2023

📚 Context

We held off on writing docstrings for this feature until the APIs mostly stabilized, etc, so now that
that has happened we're all clear to add these!

Note that these docstrings are just my initial pass for them, and it's likely that there's still going to be
a good amount of editing to do from here by the documentation team.

@vdonato vdonato added the security-assessment-completed Security assessment has been completed for PR label Apr 13, 2023
@vdonato vdonato requested review from kajarenc and lukasmasuch April 13, 2023 23:21
@vdonato
Copy link
Collaborator Author

vdonato commented Apr 15, 2023

Going to go ahead and merge this pre-review since

  • this is going into a feature branch anyway
  • the only changes made in this PR are to docstrings, so there are no behavioral changes to the feature itself
  • @snehankekre and I will be collaborating next week on polishing these docstrings into a final form before the feature branch is merged into develop

@vdonato vdonato merged this pull request into feature/st.experimental_connection Apr 15, 2023
@vdonato vdonato deleted the vdonato/connection-docstrings branch April 15, 2023 00:22
vdonato added a commit that referenced this pull request Apr 15, 2023
vdonato added a commit that referenced this pull request Apr 17, 2023
vdonato added a commit that referenced this pull request Apr 19, 2023
vdonato added a commit that referenced this pull request Apr 20, 2023
vdonato added a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants