Add retry behavior to the SQL/Snowpark read helper methods #6468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
631a509 to
ccf92e6
Compare
04f40f2 to
69b6940
Compare
69b6940 to
d0a5403
Compare
Collaborator
|
LGTM! 👍 |
kajarenc
approved these changes
Apr 12, 2023
vdonato
added a commit
that referenced
this pull request
Apr 15, 2023
* Add tenacity as an "optional dependency" for the library (but a dependency for connections) * Add retries to SQL.read_sql * Add retries to Snowpark.read_sql * Fix tests failing due to rebase
vdonato
added a commit
that referenced
this pull request
Apr 17, 2023
* Add tenacity as an "optional dependency" for the library (but a dependency for connections) * Add retries to SQL.read_sql * Add retries to Snowpark.read_sql * Fix tests failing due to rebase
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
* Add tenacity as an "optional dependency" for the library (but a dependency for connections) * Add retries to SQL.read_sql * Add retries to Snowpark.read_sql * Fix tests failing due to rebase
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Add tenacity as an "optional dependency" for the library (but a dependency for connections) * Add retries to SQL.read_sql * Add retries to Snowpark.read_sql * Fix tests failing due to rebase
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Add tenacity as an "optional dependency" for the library (but a dependency for connections) * Add retries to SQL.read_sql * Add retries to Snowpark.read_sql * Fix tests failing due to rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR adds simple retry behavior to the
read_sqlhelper methods of theSQLandSnowparkconnectors. We rely on the
tenacitylibrary to implement this, which we add as a "dependency" onlywhen actually using a connection.
For now, the behavior is quite simplistic:
developexperimental_namespace.
attempt to use recreates the underlying connection object.